<div dir="ltr"><div><div><div><div><div><div><div>Interesting update on my realpath change. When do make busyboxtest with my change, I see this:<br><br></div># realpath ../nestedvm/src<br></div>/home/davidehrmann/nestedvm/src<br><br></div>(FreeBSD and Debian's realpath implementations do this)<br><br></div>Without my change, I see this:<br></div><br># realpath ../nestedvm/src<br></div>realpath: ../nestedvm/src:<br><br></div>(which is just bizarre)<br><div><div><div><br></div><div>When I remove the bit in my change that prepends "/", I get:<br><br># realpath ../nestedvm/src<br>home/davidehrmann/nestedvm/src<br><br></div><div>Tools like ls fail on that path.<br><br></div><div>I think my change is on the right track.<br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 12, 2014 at 10:45 PM, David Ehrmann <span dir="ltr"><<a href="mailto:ehrmann@gmail.com" target="_blank">ehrmann@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I made a few changes to NestedVM that can be found here:<br><br><a href="https://github.com/ehrmann/nestedvm/compare/windows-runtime-compat3" target="_blank">https://github.com/ehrmann/nestedvm/compare/windows-runtime-compat3</a><br><br>They're described in the commits logs, but I'm not sure some of them are quit ready to be merged, yet, so I welcome any feedback.<br><br>dbf0e18: I like the approach in code (dup2 is even the canonical way it's done after a fork), but I'm not sure if I like the static util methods.<br><br>2d5b544: normalizePath doesn't return absolute paths if it was given a relative path, it just prepends the cwd. This causes issues in sys_realpath because the return path looks like a relative path, and it will fail to open. There might have been some logic in it not returning absolute paths, but I'm not sure what it is. Also, what's the difference between throwing an ErrnoException and returning -<err_code>? And what if I want to return -1 and set errno?<br></div>
</blockquote></div><br></div>